From 1888a84b7eda9e051bafa7657e72767901d6f519 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 9 Jul 2013 16:22:50 -0700
Subject: [PATCH] Fix an issue with setting "Real Name Attributes" in LDAP auth

Summary: We currently don't read/save this value correctly. Fix the issue. Ref T1536.

Test Plan: Set real name attributes to "x, y".

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, colegleason

Maniphest Tasks: T1536

Differential Revision: https://secure.phabricator.com/D6388
---
 .../provider/PhabricatorAuthProviderLDAP.php     | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/src/applications/auth/provider/PhabricatorAuthProviderLDAP.php b/src/applications/auth/provider/PhabricatorAuthProviderLDAP.php
index a3f0432937..fa8e295b78 100644
--- a/src/applications/auth/provider/PhabricatorAuthProviderLDAP.php
+++ b/src/applications/auth/provider/PhabricatorAuthProviderLDAP.php
@@ -185,20 +185,7 @@ final class PhabricatorAuthProviderLDAP
   const KEY_ACTIVEDIRECTORY_DOMAIN  = 'ldap:activedirectory-domain';
 
   private function getPropertyKeys() {
-    return array(
-      self::KEY_HOSTNAME,
-      self::KEY_PORT,
-      self::KEY_DISTINGUISHED_NAME,
-      self::KEY_SEARCH_ATTRIBUTE,
-      self::KEY_USERNAME_ATTRIBUTE,
-      self::KEY_VERSION,
-      self::KEY_REFERRALS,
-      self::KEY_START_TLS,
-      self::KEY_ANONYMOUS_USERNAME,
-      self::KEY_ANONYMOUS_PASSWORD,
-      self::KEY_SEARCH_FIRST,
-      self::KEY_ACTIVEDIRECTORY_DOMAIN,
-    );
+    return array_keys($this->getPropertyLabels());
   }
 
   private function getPropertyLabels() {
@@ -239,6 +226,7 @@ final class PhabricatorAuthProviderLDAP
           break;
       }
     }
+
     return $values;
   }