Mark fields as required on MenuItems

Summary: Mark required fields as required. Though in testing, none of these work.

Test Plan: Try to save a form without an app/project/dashboard and see success (not expected)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17231
This commit is contained in:
Chad Little 2017-01-19 13:23:42 -08:00
parent 1bcc8a3d98
commit 14dfff9c99
4 changed files with 4 additions and 0 deletions

View file

@ -34,6 +34,7 @@ final class PhabricatorApplicationProfileMenuItem
id(new PhabricatorDatasourceEditField()) id(new PhabricatorDatasourceEditField())
->setKey('application') ->setKey('application')
->setLabel(pht('Application')) ->setLabel(pht('Application'))
->setIsRequired(true)
->setDatasource(new PhabricatorApplicationDatasource()) ->setDatasource(new PhabricatorApplicationDatasource())
->setSingleValue($config->getMenuItemProperty('application')), ->setSingleValue($config->getMenuItemProperty('application')),
); );

View file

@ -77,6 +77,7 @@ final class PhabricatorDashboardProfileMenuItem
id(new PhabricatorDatasourceEditField()) id(new PhabricatorDatasourceEditField())
->setKey('dashboardPHID') ->setKey('dashboardPHID')
->setLabel(pht('Dashboard')) ->setLabel(pht('Dashboard'))
->setIsRequired(true)
->setDatasource(new PhabricatorDashboardDatasource()) ->setDatasource(new PhabricatorDashboardDatasource())
->setSingleValue($config->getMenuItemProperty('dashboardPHID')), ->setSingleValue($config->getMenuItemProperty('dashboardPHID')),
); );

View file

@ -85,6 +85,7 @@ final class PhabricatorEditEngineProfileMenuItem
id(new PhabricatorDatasourceEditField()) id(new PhabricatorDatasourceEditField())
->setKey('formKey') ->setKey('formKey')
->setLabel(pht('Form')) ->setLabel(pht('Form'))
->setIsRequired(true)
->setDatasource(new PhabricatorEditEngineDatasource()) ->setDatasource(new PhabricatorEditEngineDatasource())
->setSingleValue($config->getMenuItemProperty('formKey')), ->setSingleValue($config->getMenuItemProperty('formKey')),
); );

View file

@ -78,6 +78,7 @@ final class PhabricatorProjectProfileMenuItem
id(new PhabricatorDatasourceEditField()) id(new PhabricatorDatasourceEditField())
->setKey('project') ->setKey('project')
->setLabel(pht('Project')) ->setLabel(pht('Project'))
->setIsRequired(true)
->setDatasource(new PhabricatorProjectDatasource()) ->setDatasource(new PhabricatorProjectDatasource())
->setSingleValue($config->getMenuItemProperty('project')), ->setSingleValue($config->getMenuItemProperty('project')),
); );