minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Fix handling of "null" domain values in Charts

Browse source 
Summary: Depends on D20487. If you `min(1, 2, null)`, you get `null`. We want `1`.

Test Plan: Viewed a "burnup for project X" chart where one dataseries had no datapoints. Saw a sensible domain selected automatically.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Differential Revision: https://secure.phabricator.com/D20488
This commit is contained in:
epriestley 2019-04-30 06:49:28 -07:00
parent 146317f2c4
commit 10afe1f2b5
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/fact/chart/PhabricatorHigherOrderChartFunction.php
View file

@ -10,10 +10,14 @@ abstract class PhabricatorHigherOrderChartFunction
$domain = $function->getDomain();
if ($domain !== null) {
list($min, $max) = $domain;
if ($min !== null) {
$minv[] = $min;
}
if ($max !== null) {
$maxv[] = $max;
}
}
}
if (!$minv && !$maxv) {
return null;