minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Correct two straggling "%Q" + "implode(...)" callsites in Revision updates

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/error-seems-to-be-related-with-da40f8074-and-php-7-3/2102/12>. When creating or updating revisions, we do some manual query construction to update the affected path table.

Update these queries to modern `qsprintf()`.

Test Plan: Created and updated revisions affecting paths, no more logs in the webserver log.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19846
This commit is contained in:
epriestley 2018-12-05 06:12:08 -08:00
parent b88a87c43a
commit 1029081b28
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -1367,9 +1367,9 @@ final class DifferentialTransactionEditor
foreach (array_chunk($sql, 256) as $chunk) { foreach (array_chunk($sql, 256) as $chunk) {
queryfx( queryfx(
$conn_w, $conn_w,
'INSERT INTO %T (repositoryID, pathID, epoch, revisionID) VALUES %Q', 'INSERT INTO %T (repositoryID, pathID, epoch, revisionID) VALUES %LQ',
$table->getTableName(), $table->getTableName(),
implode(', ', $chunk)); $chunk);
} }
} }
@ -1444,9 +1444,9 @@ final class DifferentialTransactionEditor
if ($sql) { if ($sql) {
queryfx( queryfx(
$conn_w, $conn_w,
'INSERT INTO %T (revisionID, type, hash) VALUES %Q', 'INSERT INTO %T (revisionID, type, hash) VALUES %LQ',
ArcanistDifferentialRevisionHash::TABLE_NAME, ArcanistDifferentialRevisionHash::TABLE_NAME,
implode(', ', $sql)); $sql);
} }
} }