From 0f919ecd3ccf1e9f49ff94133d92a61e9b67e1c7 Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 13 Aug 2012 14:34:34 -0700 Subject: [PATCH] Update line count after attaching commit diff Summary: We should probably do this also in `differential.creatediff` but it's not a big deal because we later call `differential.updaterevision` which does this using `DifferentialRevisionEditor`. Test Plan: None. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3263 --- .../PhabricatorRepositoryCommitMessageParserWorker.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php index 1ed4eab633..77d743861e 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php @@ -217,6 +217,8 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker // TODO: Attach binary files. + $revision->setLineCount($diff->getLineCount()); + return $diff->save(); }