From 0ed5569e9f7b4ed7220ac559144fdb42488a68e9 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 17 Jul 2020 19:42:45 -0700 Subject: [PATCH] Likely, fix a warning when rendering modified coverage Summary: See PHI1819. This structure may have `null` elements. Test Plan: Will confirm user reproduction case. Differential Revision: https://secure.phabricator.com/D21420 --- .../differential/parser/DifferentialChangesetParser.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php index 45da82118f..1cc1c3ad9d 100644 --- a/src/applications/differential/parser/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/DifferentialChangesetParser.php @@ -1327,6 +1327,10 @@ final class DifferentialChangesetParser extends Phobject { $not_covered = 0; foreach ($this->new as $k => $new) { + if ($new === null) { + continue; + } + if (!$new['line']) { continue; }