From 0b99d685dfefe45e19d24aade6eebcb6bb9642bc Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Thu, 5 Jun 2025 13:58:17 +0200 Subject: [PATCH] PHPDoc: Replace non-existing return type markup with string Summary: `markup` is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html. Test Plan: Read docs; run static code analysis. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26064 --- .../differential/render/DifferentialChangesetHTMLRenderer.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php b/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php index eff9df9c83..84f72db84f 100644 --- a/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php +++ b/src/applications/differential/render/DifferentialChangesetHTMLRenderer.php @@ -495,7 +495,7 @@ abstract class DifferentialChangesetHTMLRenderer * @param int $len Length of the line range to build links for. * @param int $changeset_length Total number of lines in the changeset. * @param bool $is_blocks (optional) - * @return markup Rendered links. + * @return string Rendered links. */ protected function renderShowContextLinks( $top, @@ -584,7 +584,7 @@ abstract class DifferentialChangesetHTMLRenderer * @param bool $is_all Does this link show all context when clicked? * @param string $range Range specification for lines to show. * @param string $text Text of the link. - * @return markup Rendered link. + * @return string Rendered link. */ private function renderShowContextLink($is_all, $range, $text) { $reference = $this->getRenderingReference();