From 07e40af06a7a1508e8c8f933f9732b5f520f1d87 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Thu, 8 May 2025 15:18:38 +0200 Subject: [PATCH] Remove orphan CSS selectors in ponder/ponder-view.css Summary: * `ponder-answer-wiki-header` ** Added in https://we.phorge.it/rPe9f4ca6ca338142b2cf44e61d313d3c6810435d4, usage removed in https://we.phorge.it/rPfe7e288cf558051c5405679d8569ce26847482ef * `ponder-question-container` ** Added in https://we.phorge.it/rPe9f4ca6ca338142b2cf44e61d313d3c6810435d4, seems to never have been used * `ponder-view-properties` ** Added in https://we.phorge.it/rPe9f4ca6ca338142b2cf44e61d313d3c6810435d4, usage removed in https://we.phorge.it/rPfe7e288cf558051c5405679d8569ce26847482ef Test Plan: Grep the code for each CSS selector (`grep --exclude="*.css" -R 'some-search-string' .`), also do partial searches, get no results. Visit a Ponder question, both in frontend and backend, and play with these selectors. Nothing happens. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25999 --- resources/celerity/map.php | 4 ++-- .../css/application/ponder/ponder-view.css | 23 ------------------- 2 files changed, 2 insertions(+), 25 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 19a6baacde..aae2f1882f 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -97,7 +97,7 @@ return array( 'rsrc/css/application/policy/policy-edit.css' => '8794e2ed', 'rsrc/css/application/policy/policy-transaction-detail.css' => 'c02b8384', 'rsrc/css/application/policy/policy.css' => 'ceb56a08', - 'rsrc/css/application/ponder/ponder-view.css' => 'b04bbaff', + 'rsrc/css/application/ponder/ponder-view.css' => 'ce35bda1', 'rsrc/css/application/project/project-card-view.css' => 'a9f2c2dd', 'rsrc/css/application/project/project-triggers.css' => 'cd9c8bb9', 'rsrc/css/application/project/project-view.css' => '567858b3', @@ -894,7 +894,7 @@ return array( 'policy-css' => 'ceb56a08', 'policy-edit-css' => '8794e2ed', 'policy-transaction-detail-css' => 'c02b8384', - 'ponder-view-css' => 'b04bbaff', + 'ponder-view-css' => 'ce35bda1', 'project-card-view-css' => 'a9f2c2dd', 'project-triggers-css' => 'cd9c8bb9', 'project-view-css' => '567858b3', diff --git a/webroot/rsrc/css/application/ponder/ponder-view.css b/webroot/rsrc/css/application/ponder/ponder-view.css index 675bc205b7..f72dad390a 100644 --- a/webroot/rsrc/css/application/ponder/ponder-view.css +++ b/webroot/rsrc/css/application/ponder/ponder-view.css @@ -2,27 +2,12 @@ * @provides ponder-view-css */ -.ponder-question-container { - border-top: 1px solid {$thinblueborder}; -} - -.device .ponder-view-properties { - border-left: none; - border-right: none; - border-radius: 0; -} - .device .ponder-question-view .phui-timeline-view, .device .ponder-question-view .phui-timeline-event-view { margin: 0; padding: 0; } -.ponder-view-properties .phui-property-list-container { - margin: 0; - padding: 0; -} - .ponder-question-view .phui-document-container { border: none; } @@ -91,14 +76,6 @@ border-radius: 3px; } -.ponder-answer-wiki-header { - font-weight: bold; - border-bottom: 1px solid {$lightblueborder}; - color: {$bluetext}; - padding-bottom: 8px; - margin-bottom: 16px; -} - .ponder-footer-view { text-align: left; margin-top: 16px;